Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide diffing for dataflow graphs #495

Merged
merged 11 commits into from
Dec 4, 2023

Conversation

EagleoutIce
Copy link
Member

Helper for #439 (what the id-coincidence).

@EagleoutIce EagleoutIce linked an issue Nov 10, 2023 that may be closed by this pull request
@EagleoutIce EagleoutIce changed the title Improve diffing of dataflow graphs Provide diffing of dataflow graphs Nov 10, 2023
@EagleoutIce EagleoutIce changed the title Provide diffing of dataflow graphs Provide diffing for dataflow graphs Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (ef1fac5) 70.84% compared to head (8cc1189) 70.95%.

Files Patch % Lines
src/dataflow/graph/diff.ts 68.85% 23 Missing and 15 partials ⚠️
src/dataflow/environments/environment.ts 20.51% 18 Missing and 13 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
+ Coverage   70.84%   70.95%   +0.10%     
==========================================
  Files         212      213       +1     
  Lines        6665     6730      +65     
  Branches     1025     1042      +17     
==========================================
+ Hits         4722     4775      +53     
- Misses       1678     1682       +4     
- Partials      265      273       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce
Copy link
Member Author

Fine => Merge

@EagleoutIce EagleoutIce merged commit 78a7bf4 into main Dec 4, 2023
21 checks passed
@EagleoutIce EagleoutIce deleted the 493-improve-diffing-of-dataflow-graphs branch December 4, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve diffing of dataflow graphs
1 participant