Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Variable Steps in the Dataflow Processor #509

Conversation

EagleoutIce
Copy link
Member

This revises the step system by adding dependencies to the mix, allowing to create pipelines based on a selection of steps. This pipeline is automatically resolved and ordered, and then to be given to the SteppingSlicer, which is to be renamed according to the pipeline scheme. I am open to suggestions.

While the PR provides full compatibility at the moment, i will probably break that (although the stepping slicer facade my live on for 1.x.x to provide compatibility). We should introduce a new milestone for 2.x.x and schedule the removal of said component there.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dataflow-v2@a76a029). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             dataflow-v2     #509   +/-   ##
==============================================
  Coverage               ?   66.13%           
==============================================
  Files                  ?      252           
  Lines                  ?     7480           
  Branches               ?     1139           
==============================================
  Hits                   ?     4947           
  Misses                 ?     2271           
  Partials               ?      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce
Copy link
Member Author

EagleoutIce commented Nov 22, 2023

In combination with #468, this should allow us to better separate the steps from each other, allowing to load arbitrary steps known to the program (with no more requirement that they have to appear in a const structure...). I will try my best to keep the typing inference of dependencies intact, although i will not guarantee that it works with non-linear dependency structures.

* git, doc: document new optional scope and much more readable regex in commit-msg

* feat(commit-msg): print out message even if it is invalid

* feat(commit-msg): print commit message even if it is incorrect

* doc: refer to the contributin md instead of just printing the regex if the git commit message is wrong

* refactor(commit-msg): slightly reformat output

* refactor(commit-msg): remove the `log` type

* doc(contributing): document new scopes for commit messages
@EagleoutIce EagleoutIce marked this pull request as ready for review November 29, 2023 20:38
@EagleoutIce EagleoutIce merged commit b028faa into dataflow-v2 Nov 29, 2023
9 checks passed
@EagleoutIce EagleoutIce deleted the 508-allow-multiple-functions-to-be-used-as-dataflow-processors branch November 29, 2023 20:43
@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.0 (see Release v2.0.0 (Dataflow v2)).

4 similar comments
@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.0 (see Release v2.0.0 (Dataflow v2)).

@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.0 (see Release v2.0.0 (Dataflow v2)).

@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.0 (see Release v2.0.0 (Dataflow v2)).

@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.0 (see Release v2.0.0 (Dataflow v2)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant