Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforcing Conventional Commits #521

Merged
merged 9 commits into from
Dec 1, 2023
Merged

Enforcing Conventional Commits #521

merged 9 commits into from
Dec 1, 2023

Conversation

EagleoutIce
Copy link
Member

@EagleoutIce EagleoutIce commented Nov 29, 2023 •
edited
Loading

We need to:

  • update contributing and wiki information
  • port the pre-commit git-hook
  • configure the conventions we follow

@EagleoutIce EagleoutIce linked an issue Nov 29, 2023 that may be closed by this pull request
Should we move to "conventional commits"? #513
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f86a20d) 70.84% compared to head (ddfb721) 70.84%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   70.84%   70.84%           
=======================================
  Files         212      212           
  Lines        6665     6665           
  Branches     1025     1025           
=======================================
  Hits         4722     4722           
  Misses       1678     1678           
  Partials      265      265

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce
Copy link
Member Author

How do you like the configuration @LukasPietzschmann and @Ehcsan.
If you are at it, we may want to join this add-on with the (hopefully) improvements of #517. What do you say?

@EagleoutIce EagleoutIce mentioned this pull request Nov 30, 2023
Closed
Ehcsan
Ehcsan approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@Ehcsan Ehcsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem good, however I may want to test these again with GitHub Desktop after the merge is completed

@EagleoutIce EagleoutIce merged commit 10f8916 into main Dec 1, 2023
13 checks passed
@EagleoutIce EagleoutIce deleted the 513-move-to-conventional-commits branch December 1, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ehcsan Ehcsan Ehcsan approved these changes

@LukasPietzschmann LukasPietzschmann Awaiting requested review from LukasPietzschmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we move to "conventional commits"?
2 participants
@EagleoutIce @Ehcsan