Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop readlines/promises Dependency #595

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

EagleoutIce
Copy link
Member

No description provided.

@EagleoutIce EagleoutIce linked an issue Jan 15, 2024 that may be closed by this pull request
@EagleoutIce
Copy link
Member Author

Additionally this makes the joi import more non-esm-interop compatible

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (00656bb) 71.12% compared to head (54d8476) 71.08%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/cli/repl/core.ts 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   71.12%   71.08%   -0.05%     
==========================================
  Files         213      213              
  Lines        6770     6774       +4     
  Branches     1053     1053              
==========================================
  Hits         4815     4815              
- Misses       1681     1685       +4     
  Partials      274      274              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce merged commit 07a1487 into main Jan 15, 2024
22 checks passed
@EagleoutIce EagleoutIce deleted the 592-check-dependencies-required-for-npm branch January 15, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Dependencies Required for NPM
1 participant