Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize V2: Adapt remaining access tests #598

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Jan 16, 2024

No description provided.

@Ellpeck Ellpeck linked an issue Jan 16, 2024 that may be closed by this pull request
@EagleoutIce
Copy link
Member

I fixed the token type mapping in 1f07e04, the error I made was rather... simple. Normally it should split the arguments on every , (comma) but for that i require the token map configuration used by xmlparsedata. In other words. It tried to parse 5,3 as a single argument instead of processing 5 and 3 separately.

…-access-tests' into 597-normalize-v2-adapt-remaining-access-tests
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4676f74) 66.56% compared to head (83d497f) 66.71%.
Report is 6 commits behind head on 572-normalize-v2-desugaring.

Files Patch % Lines
...x/ast/parser/xml/v2/internal/functions/argument.ts 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           572-normalize-v2-desugaring     #598      +/-   ##
===============================================================
+ Coverage                        66.56%   66.71%   +0.14%     
===============================================================
  Files                              270      271       +1     
  Lines                             7848     7853       +5     
  Branches                          1204     1206       +2     
===============================================================
+ Hits                              5224     5239      +15     
+ Misses                            2336     2323      -13     
- Partials                           288      291       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ellpeck Ellpeck marked this pull request as ready for review January 16, 2024 11:59
@EagleoutIce EagleoutIce self-requested a review January 17, 2024 09:16
@EagleoutIce EagleoutIce merged commit 9435206 into 572-normalize-v2-desugaring Jan 17, 2024
8 checks passed
@EagleoutIce EagleoutIce deleted the 597-normalize-v2-adapt-remaining-access-tests branch January 17, 2024 10:19
@EagleoutIce
Copy link
Member

This pull request is included in v2.0.0 (see Release v2.0.0 (Dataflow v2)).

1 similar comment
@EagleoutIce
Copy link
Member

This pull request is included in v2.0.0 (see Release v2.0.0 (Dataflow v2)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize V2: Adapt remaining access tests
2 participants