Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Avoid async when interfacing with the R shell #615

Merged

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Jan 24, 2024

Also known as: add entirely synchronous RShellExecutor class

@Ellpeck Ellpeck linked an issue Jan 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (75a417d) 71.03% compared to head (bd5a388) 71.24%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/r-bridge/shell-executor.ts 87.01% 6 Missing and 4 partials ⚠️
src/r-bridge/shell.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
+ Coverage   71.03%   71.24%   +0.20%     
==========================================
  Files         213      215       +2     
  Lines        6774     6858      +84     
  Branches     1053     1061       +8     
==========================================
+ Hits         4812     4886      +74     
- Misses       1685     1691       +6     
- Partials      277      281       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ellpeck Ellpeck marked this pull request as ready for review January 24, 2024 12:57
@Ellpeck Ellpeck marked this pull request as draft January 24, 2024 13:06
@Ellpeck Ellpeck marked this pull request as ready for review January 24, 2024 13:23
src/r-bridge/shell-executor.ts Outdated Show resolved Hide resolved
src/r-bridge/shell-executor.ts Show resolved Hide resolved
src/r-bridge/shell-executor.ts Outdated Show resolved Hide resolved
test/functionality/r-bridge/executor.ts Show resolved Hide resolved
src/r-bridge/shell-executor.ts Show resolved Hide resolved
@EagleoutIce EagleoutIce merged commit f059b24 into main Jan 25, 2024
21 checks passed
@EagleoutIce EagleoutIce deleted the 610-refactor-avoid-async-when-interfacing-with-the-r-shell branch January 25, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Avoid async when interfacing with the R shell
2 participants