-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist history of flowR REPL sessions #641
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 71.34% 71.34% -0.01%
==========================================
Files 217 217
Lines 7005 7015 +10
Branches 1085 1087 +2
==========================================
+ Hits 4998 5005 +7
- Misses 1720 1722 +2
- Partials 287 288 +1 ☔ View full report in Codecov by Sentry. |
in case someone uses a different file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wuhuuu!
Theoretically, we have a problem when someone runs multiple repls at the same time which overwrite each other but hey... we live only once! |
Thoretically, we could keep a stream to the history file open while repl is active and store the history into the file that way. Then, we could just print a warning and skip storing the history for any sessions that are started on top of the original one. |
Yes, or we could keep a History-Tree but I think the current handling is sufficient as the most frequent use case will be the restart of the repl after compilation |
This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)). |
persistory