Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance fixes for #659 #684

Merged
merged 31 commits into from
Feb 24, 2024

feat(tests): cover for optional xmlparsedata availability

de3b7d0
Select commit
Loading
Failed to load commit list.
Merged

Performance fixes for #659 #684

feat(tests): cover for optional xmlparsedata availability
de3b7d0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 24, 2024 in 0s

67.27% (target 80.00%)

View this Pull Request on Codecov

67.27% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 89.90826% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 67.27%. Comparing base (5617885) to head (de3b7d0).
Report is 1 commits behind head on main.

Files Patch % Lines
src/r-bridge/shell.ts 62.50% 4 Missing and 2 partials ⚠️
src/cli/repl/commands/parse.ts 66.66% 1 Missing ⚠️
src/core/print/parse-printer.ts 66.66% 1 Missing ⚠️
src/r-bridge/lang-4.x/ast/parser/json/format.ts 93.33% 0 Missing and 1 partial ⚠️
src/r-bridge/lang-4.x/ast/parser/json/parser.ts 92.30% 1 Missing ⚠️
src/r-bridge/shell-executor.ts 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   71.37%   67.27%   -4.11%     
==========================================
  Files         218      217       -1     
  Lines        7082     7041      -41     
  Branches     1092     1092              
==========================================
- Hits         5055     4737     -318     
- Misses       1737     2053     +316     
+ Partials      290      251      -39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov