Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Environments in Dataflow Tests #696

Merged
merged 12 commits into from
Mar 8, 2024

Conversation

bjthehun
Copy link
Contributor

@bjthehun bjthehun commented Mar 1, 2024

Closes #691:

  • Helper functions for variable/R function/etc. definitions
  • Replace previous definitions in defines
  • Also: (optionally named) argumentInCalls for function call vertices
  • Simplify environment definitions themselves

@EagleoutIce
Copy link
Member

I really like this so far. It would be nice to have another builder-like pattern for the environments as well. Especially to avoid the otherwise required merges to achieve maybes/sets of values.

Thank you!

@bjthehun
Copy link
Contributor Author

bjthehun commented Mar 1, 2024

I really like this so far. It would be nice to have another builder-like pattern for the environments as well. Especially to avoid the otherwise required merges to achieve maybes/sets of values.

OK.

Copy link
Member

@EagleoutIce EagleoutIce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@EagleoutIce EagleoutIce merged commit d4ad9bd into flowr-analysis:main Mar 8, 2024
13 checks passed
@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

1 similar comment
@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Environments for Dataflow Tests
2 participants