Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startup argument and flowr config file entry for changing the R shell's R executable #718

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Mar 11, 2024

precedence order is repl -> config -> default, which i think makes sense

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.14%. Comparing base (d4ad9bd) to head (9c890d0).
Report is 10 commits behind head on main.

Files Patch % Lines
src/r-bridge/shell.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   71.13%   71.14%           
=======================================
  Files         217      217           
  Lines        7033     7035    +2     
  Branches     1095     1096    +1     
=======================================
+ Hits         5003     5005    +2     
  Misses       1738     1738           
  Partials      292      292           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/flowr.ts Outdated Show resolved Hide resolved
src/flowr.ts Outdated Show resolved Hide resolved
Ellpeck and others added 2 commits March 11, 2024 17:24
Co-authored-by: Florian Sihler <florian.sihler@uni-ulm.de>
@EagleoutIce EagleoutIce merged commit 84f42a6 into main Mar 11, 2024
21 checks passed
@EagleoutIce EagleoutIce deleted the 708-add-startup-argument-andor-flowr-config-file-entry-for-changing-the-r-shells-r-executable branch March 11, 2024 17:02
Ellpeck added a commit that referenced this pull request Mar 14, 2024
from [this situation](#718 (comment)), good job us
@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add startup argument (and/or flowr config file entry) for changing the R shell's R executable
2 participants