Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to xmlparsedata from docs #723

Merged

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Mar 14, 2024

No description provided.

@Ellpeck Ellpeck linked an issue Mar 14, 2024 that may be closed by this pull request
@Ellpeck
Copy link
Member Author

Ellpeck commented Mar 14, 2024

I'm not actually sure if removing the entire meta table makes sense, but I think those are all only used in the xml generated by xmlparsedata?

@EagleoutIce
Copy link
Member

The tokens are still very well of importance! I updated the patch accordingly.

@Ellpeck
Copy link
Member Author

Ellpeck commented Mar 14, 2024

Oh, okay! Isn't that everything we need to edit then?

@EagleoutIce
Copy link
Member

Yes, i think so!

@EagleoutIce EagleoutIce merged commit 18141a9 into main Mar 14, 2024
14 checks passed
@EagleoutIce EagleoutIce deleted the 669-remove-references-to-xmlparsedata-from-documentation branch March 14, 2024 16:58
@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to xmlparsedata from documentation
2 participants