Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Repl Crashes for Invalid Input #727

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

Ellpeck
Copy link
Member

@Ellpeck Ellpeck commented Mar 15, 2024

No description provided.

@Ellpeck Ellpeck linked an issue Mar 15, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 70.79%. Comparing base (eedf276) to head (8655949).

Files Patch % Lines
src/cli/repl/commands/parse.ts 0.00% 5 Missing ⚠️
src/cli/repl/core.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   70.85%   70.79%   -0.07%     
==========================================
  Files         217      217              
  Lines        7074     7080       +6     
  Branches     1096     1096              
==========================================
  Hits         5012     5012              
- Misses       1769     1775       +6     
  Partials      293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ellpeck
Copy link
Member Author

Ellpeck commented Mar 15, 2024

hmm I'm realizing now that catching every exception in every command manually (in addition to the default catching i added in the first commit) may be a bit.. unnecessary? @EagleoutIce your opinion ✨

@EagleoutIce
Copy link
Member

I agree. Although it has the potential of allowing for ✨ better errors ✨, the default handling appears to be sufficient.

@Ellpeck Ellpeck marked this pull request as ready for review March 15, 2024 09:59
@EagleoutIce EagleoutIce merged commit b966157 into main Mar 15, 2024
19 checks passed
@EagleoutIce EagleoutIce deleted the 724-bug-repl-crashes-for-invalid-input branch March 15, 2024 10:02
@EagleoutIce
Copy link
Member

This pull request is included in v1.4.2 (see Release v1.4.2 (Dropping xmlparsedata, Benchmark Re-Runs, and Repl Fixes)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Repl Crashes for Invalid Input
2 participants