Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the stepping slicer #774

Merged
merged 9 commits into from
May 7, 2024
Merged

Removed the stepping slicer #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dee5823
refactor: removed the stepping slicer
Ellpeck May 7, 2024
4cfdc87
refactor: fix lint errors
Ellpeck May 7, 2024
387e5e1
refactor: use default pipelines where applicable
Ellpeck May 7, 2024
210ddca
Merge branch 'main' into 520-remove-the-steppingslicer
EagleoutIce May 7, 2024
7998f01
refactor: further remove old stepping-slicer files
EagleoutIce May 7, 2024
b9d35b3
refactor(pipeline): minor improvements to filenames and structure
EagleoutIce May 7, 2024
f6866fe
refactor: remove local variable in det. id generator closure
EagleoutIce May 7, 2024
90334fa
doc(interface): clean up the interface wiki page
EagleoutIce May 7, 2024
89642bb
refactor(interface): clarify that the stepping slicer was removed
EagleoutIce May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/pipeline-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import type {
PipelineStepNames,
PipelineStepOutputWithName
} from './steps/pipeline'
import type { PipelineStepName } from './steps/step'
import { PipelineStepStage } from './steps/step'
import type { PipelineStepName } from './steps/pipeline-step'
import { PipelineStepStage } from './steps/pipeline-step'

/**
* The pipeline executor allows to execute arbitrary {@link Pipeline|pipelines} in a step-by-step fashion.
Expand Down
2 changes: 1 addition & 1 deletion src/core/print/print.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { IPipelineStep, StepProcessingFunction } from '../steps/step'
import type { IPipelineStep, StepProcessingFunction } from '../steps/pipeline-step'
import type { TailOfArray } from '../../util/arrays'
import { guard } from '../../util/assert'

Expand Down
182 changes: 0 additions & 182 deletions src/core/stepping-slicer.ts
View file
Open in desktop

This file was deleted.

154 changes: 0 additions & 154 deletions src/core/steps.ts
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/core/steps/all/core/00-parse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { internalPrinter, StepOutputFormat } from '../../../print/print'
import { parseToQuads } from '../../../print/parse-printer'
import type { IPipelineStep } from '../../step'
import { PipelineStepStage } from '../../step'
import type { IPipelineStep } from '../../pipeline-step'
import { PipelineStepStage } from '../../pipeline-step'
import type { RParseRequest, RShell } from '../../../../r-bridge'
import type { DeepReadonly } from 'ts-essentials'
import type { RShellExecutor } from '../../../../r-bridge/shell-executor'
Expand Down
4 changes: 2 additions & 2 deletions src/core/steps/all/core/10-normalize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import {
printNormalizedAstToMermaid,
printNormalizedAstToMermaidUrl
} from '../../../print/normalize-printer'
import type { IPipelineStep } from '../../step'
import { PipelineStepStage } from '../../step'
import type { IPipelineStep } from '../../pipeline-step'
import { PipelineStepStage } from '../../pipeline-step'
import type { DeepReadonly } from 'ts-essentials'
import type { ParseRequiredInput } from './00-parse'
import { normalize } from '../../../../r-bridge/lang-4.x/ast/parser/json/parser'
Expand Down
4 changes: 2 additions & 2 deletions src/core/steps/all/core/20-dataflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { internalPrinter, StepOutputFormat } from '../../../print/print'
import type { IPipelineStep } from '../../step'
import { PipelineStepStage } from '../../step'
import type { IPipelineStep } from '../../pipeline-step'
import { PipelineStepStage } from '../../pipeline-step'
import {
dataflowGraphToJson,
dataflowGraphToMermaid,
Expand Down
4 changes: 2 additions & 2 deletions src/core/steps/all/core/21-abstract-interpretation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { internalPrinter, StepOutputFormat } from '../../../print/print'
import type { DataflowInformation } from '../../../../dataflow/info'
import type { IPipelineStep } from '../../step'
import type { IPipelineStep } from '../../pipeline-step'
import type { DeepReadonly } from 'ts-essentials'
import { PipelineStepStage } from '../../step'
import { PipelineStepStage } from '../../pipeline-step'

// Use runAbstractInterpretation here when it's ready
function processor(results: { dataflow?: DataflowInformation }, _input: unknown): DataflowInformation {
Expand Down
Loading
Loading