-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rich text editor (tiptap) #443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is being deployed to Railway 🚅 Server: 🚨 Build Failed |
✅ Deploy Preview for rockket canceled.
|
floydnant
force-pushed
the
dev/add-rt-editor
branch
from
May 20, 2023 00:30
5c8ceff
to
339a782
Compare
floydnant
commented
Sep 26, 2023
floydnant
commented
Sep 26, 2023
client-v2/src/app/components/molecules/entity-description/entity-description.component.ts
Outdated
Show resolved
Hide resolved
floydnant
commented
Sep 26, 2023
client-v2/src/app/rich-text-editor/tip-tap-editor/tip-tap-editor.component.ts
Outdated
Show resolved
Hide resolved
floydnant
commented
Sep 26, 2023
floydnant
force-pushed
the
dev/add-rt-editor
branch
from
November 17, 2023 10:18
2e020cf
to
2b2fe3e
Compare
floydnant
force-pushed
the
dev/add-rt-editor
branch
from
November 25, 2023 13:33
881fbce
to
03189b9
Compare
floydnant
force-pushed
the
dev/add-rt-editor
branch
from
November 26, 2023 01:06
2e7ab0b
to
5175eed
Compare
floydnant
commented
Nov 26, 2023
floydnant
commented
Nov 26, 2023
floydnant
commented
Nov 26, 2023
floydnant
commented
Nov 26, 2023
client-v2/src/app/components/molecules/entity-description/entity-description.component.ts
Show resolved
Hide resolved
floydnant
commented
Nov 26, 2023
client-v2/src/app/rich-text-editor/editor-features/blocks.feature.ts
Outdated
Show resolved
Hide resolved
floydnant
commented
Nov 26, 2023
client-v2/src/app/rich-text-editor/editor-features/extensions/search-and-replace.extension.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes/Additions
toolbar.component
andkeycombo.component
TODO
Look into dragging / switching lines→ apparently not feasibleentity-heading
Component testsFix controls in task getting scrolled out of view.icon-btn
needs to be aspect-square in some scenarios (entity-heading
)Maybe we should add a little more spacing in between list itemsOnly non empty~~<p>~~
s should have the margin-bottomWhen inserting a rule, the cursor stays inside it, overwriting it with the next typed characterReduce overhead (redundant emissions and computation) → premature optimisation?cdkMenu
Decrease margin/padding-top from headingsDecrease spacing on editor bottom (only in~~entity-description~~
)=> sth like "Save", "Save & Leave", "Save & Blur" or simply "Done"
Inline Code
<code>
is inside an<a>
inherit the text colorCtrl-e
?Markdown support
tiptap-markdown documentation
\t
in code blocksCan we specify that we want the output format to be the Github flavoured one? → otherwise we need some manual output modification~~<~~
→~~<~~
and~~>~~
→~~>~~
~~\\\\t~~
→~~\\t~~
(presumably all escaped characters like these in inline code)Safari
taskList
seems fine)hide
-styles not getting appliedBlocking mouse interaction for~~entity-heading~~
might be an issue again