Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: nx migration #534

Merged
merged 43 commits into from
Apr 4, 2024
Merged

build: nx migration #534

merged 43 commits into from
Apr 4, 2024

Conversation

floydnant
Copy link
Owner

@floydnant floydnant commented Dec 22, 2023

Resolves #427
Resolves #234
Resolves #40

️🪄 Changes

  • Init nx workspace
  • Migrate backend to nx project
  • Migrate frontend to nx project
  • Update workflow and dependabot config

💥 Breaking Changes

  • None (besides a complete codebase restructure)

Future todos

  • Add console.log() linting rule
  • Add @TODO!: linting rule (todo comments with a ! should not be merged)
  • Migrate from class-validator to zod

🧪 What/How to test this PR

  • Briefly outline what and how to test changes in this PR

✅ Checklist

  • All linter warnings are resolved and code is formatted (npm run fix)
  • Nothing is broken
    • Affected builds run (nx affected -t build)
    • Affected tests run (nx affected -t tests)
    • Affected component tests run (nx affected -t component-test)
    • Affected e2e tests run (nx affected -t e2e)
    • Affected apps can be served (nx affected -t serve)
  • Package/API versions incremented according to semantic versioning, package-lock.json updated (npm i)
  • Changes to ENV variables are reflected in the respective env.sample files
  • Breaking changes flagged
  • Code is sufficiently documented with comments
  • Docs updated to reflect changes
  • All code used for temporary testing removed (console.log() etc.)
  • Outstanding todos marked with @TODO comments
  • All commented out code removed

Backend only

  • If the schema changed, migrations are generated and tested

Frontend only

  • Tested on mobile device

@floydnant floydnant self-assigned this Dec 22, 2023
Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for rockket canceled.

Name Link
🔨 Latest commit d2e84c5
🔍 Latest deploy log https://app.netlify.com/sites/rockket/deploys/660dcc77e3c27f0007afdbad

@github-actions github-actions bot added the documentation Changes to documentation label Dec 28, 2023
@github-actions github-actions bot added dependencies Pull requests that update a dependency file web Issue related to the front end backend Related to the back end config Changes affecting configuration env-updated Changes affecting environment variables, represented by changes to `env.sample` files. db-schema-updated Changes affecting the database schema or migrations labels Dec 28, 2023
Copy link

nx-cloud bot commented Apr 3, 2024

@floydnant floydnant force-pushed the build/nx-migration branch from 8210b54 to d2e84c5 Compare April 3, 2024 21:39
@floydnant floydnant merged commit b547538 into main Apr 4, 2024
12 checks passed
@floydnant floydnant deleted the build/nx-migration branch April 4, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the back end config Changes affecting configuration db-schema-updated Changes affecting the database schema or migrations dependencies Pull requests that update a dependency file documentation Changes to documentation env-updated Changes affecting environment variables, represented by changes to `env.sample` files. web Issue related to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to nx Extract railway config into a config file Replace karma and jasmine with better options
1 participant