Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix minor issues in landing page and search #609

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

floydnant
Copy link
Owner

️πŸͺ„ Changes

  • Fix reference to COMPLETED icon on the landing page
  • Fix the landing page demos not displaying the new priority and status types
  • Fix the tasklist description styling in the search results

πŸ§ͺ What/How to test this PR

πŸ“‹ Checklist

  • All linter warnings are resolved and code is formatted (npm run fix)
  • Affected projects build and test successfully (npm run affected)
  • Apps can be served (npm run dev)
  • Changes to ENV variables are reflected in the respective env.sample files
  • Breaking changes flagged
  • BE If the schema changed, migrations are generated and tested
  • FE Tested on mobile device (npm run dev:lan)
  • Misc Code is sufficiently documented with comments
  • Misc Docs updated to reflect changes
  • Misc All code used for temporary testing removed (console.log() etc.)
  • Misc Outstanding todos marked with @TODO comments
  • Misc All commented out code removed

@floydnant floydnant self-assigned this Jun 20, 2024
Copy link

netlify bot commented Jun 20, 2024

βœ… Deploy Preview for rockket ready!

Name Link
πŸ”¨ Latest commit 87f5623
πŸ” Latest deploy log https://app.netlify.com/sites/rockket/deploys/66744151cd8f44000813e4a5
😎 Deploy Preview https://deploy-preview-609--rockket.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 33
Accessibility: 84
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web Issue related to the front end label Jun 20, 2024
@floydnant floydnant enabled auto-merge (squash) June 20, 2024 14:49
Copy link

nx-cloud bot commented Jun 20, 2024

@floydnant floydnant merged commit 5da25e4 into main Jun 20, 2024
12 checks passed
@floydnant floydnant deleted the fix/landing-page-and-search branch June 20, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web Issue related to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant