Skip to content

fix: fix editor being focusable when not editable #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

floydnant
Copy link
Owner

️πŸͺ„ Changes

πŸ§ͺ What/How to test this PR

πŸ“‹ Checklist

  • All linter warnings are resolved and code is formatted (npm run fix)
  • Affected projects build and test successfully (npm run affected)
  • Apps can be served (npm run dev)
  • Changes to ENV variables are reflected in the respective env.sample files
  • Breaking changes flagged
  • BE If the schema changed, migrations are generated and tested
  • FE Tested on mobile device (npm run dev:lan)
  • Misc Code is sufficiently documented with comments
  • Misc Docs updated to reflect changes
  • Misc All code used for temporary testing removed (console.log() etc.)
  • Misc Outstanding todos marked with @TODO comments
  • Misc All commented out code removed

@floydnant floydnant self-assigned this Jan 19, 2025
@github-actions github-actions bot added the web Issue related to the front end label Jan 19, 2025
Copy link

nx-cloud bot commented Jan 19, 2025

View your CI Pipeline Execution β†— for commit 151fa7e.

Command Status Duration Result
nx component-test rockket-web βœ… Succeeded 2m 34s View β†—
nx e2e rockket-web-e2e βœ… Succeeded 2m 5s View β†—
nx run rockket-web:test:ci βœ… Succeeded 52s View β†—
nx build rockket-web βœ… Succeeded 49s View β†—
nx e2e rockket-backend-e2e βœ… Succeeded 2s View β†—
nx run rockket-backend:test:ci βœ… Succeeded <1s View β†—
nx run rockket-backend:db:migrate:deploy βœ… Succeeded 1s View β†—
nx typecheck-snapshot-scripts rockket-backend βœ… Succeeded 2s View β†—
Additional runs (4) βœ… Succeeded ... View β†—

☁️ Nx Cloud last updated this comment at 2025-01-19 01:16:08 UTC

Copy link

netlify bot commented Jan 19, 2025

βœ… Deploy Preview for rockket ready!

Name Link
πŸ”¨ Latest commit 151fa7e
πŸ” Latest deploy log https://app.netlify.com/sites/rockket/deploys/678c511ddc3fea0008ec05e4
😎 Deploy Preview https://deploy-preview-652--rockket.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 32
Accessibility: 84
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@floydnant floydnant merged commit 8c7f98d into main Jan 19, 2025
12 checks passed
@floydnant floydnant deleted the fix/editor-focus branch January 19, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web Issue related to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant