Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PVR addon API v6.0.0 #2

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Implement PVR addon API v6.0.0 #2

merged 1 commit into from
Apr 25, 2019

Conversation

flubshi
Copy link
Owner

@flubshi flubshi commented Apr 24, 2019

Implement API changes.

How Has This Been Tested?
I compiled kodi including xbmc/xbmc#15953 and this version of pvr.waipu. The pvr plugin seems to work with this API version. TV streams start playback as expected.

@ksooo could you please take a short look at this change? Thanks!

@flubshi flubshi requested a review from ksooo April 24, 2019 21:18
@ksooo
Copy link
Collaborator

ksooo commented Apr 24, 2019

Will do, but please, do not merge for now.

@ksooo
Copy link
Collaborator

ksooo commented Apr 25, 2019

Failed Travis builds can be ignored for now. They were introduced with a recent unrelated Kodi PR.

Copy link
Collaborator

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ksooo ksooo merged commit 7ad499e into Matrix Apr 25, 2019
@flubshi flubshi deleted the pvr-api-6-0-0 branch April 25, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants