Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes non-initialisation for NRT version of AmpGate. #261

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

tremblap
Copy link
Member

@tremblap tremblap commented Feb 4, 2024

This seems to fix the filter having memories between calls. @weefuzzy I just have 2 very quick questions for you:

  • is the NRT adaptor running init on all those automagically converted? I don't know where to look so any pointers welcome.
  • is the way I do it in this PR for that object which has its own magic adaptor the right way?

Thanks for your help

@tremblap
Copy link
Member Author

tremblap commented Feb 4, 2024

https://discourse.flucoma.org/t/problems-batch-slicing-with-fluid-bufampgate/2192/6

Pd patch available should that be preferred.

@weefuzzy
Copy link
Member

weefuzzy commented Feb 4, 2024

  • is the NRT adaptor running init on all those automagically converted? I don't know where to look so any pointers welcome.

If init == reset then, yes. The adaptor for AmpGate isn't any more magic than the others, it just needs its own because it's a weirdo. The trouble being that, as here, gremlins are prone to creep in because duplication.

The equivalent code for the other slicers is here in FluidClientNRTWrapper.hpp (which is a prime candidate for breaking up into more digestible pieces, because huge):

std::vector<HostVectorView> input{{nullptr, 0, 0}};
std::vector<HostVectorView> output{{nullptr, 0, 0}};
client.reset(c);
for (index i = 0, N = nHops; i < N; ++i)
{
input[0] = monoSource.row(0)(Slice(i * VectorSize, VectorSize));

  • is the way I do it in this PR for that object which has its own magic adaptor the right way?

Just adding a reset call? Seems reasonable – that's what everything else does; the variation is whether is has to be done repeatedly (for the multichannel case) or not.

@tremblap
Copy link
Member Author

tremblap commented Feb 4, 2024

thanks so much for the quick reply - I'll study that wrapper which will become handy with the biz adaptor needed for voiceallocator!

@tremblap tremblap merged commit 398601a into flucoma:main Feb 4, 2024
3 checks passed
@tremblap tremblap deleted the nrt-ampgate-init-fix branch February 4, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants