-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #256 - checking input to env with filters #263
Conversation
See my last comment on the issue. I think there's a better solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logically looks fine. I have only stylistic consistency nitpicks, at least one of which should have been caught by clang-format:
- We've been using newline before braces everywhere, IIRC. clang-format should be doing this.
- Prefer brace-initialization of the member variable if that's how all the others are done
- Maybe this has just passed the threshold of fiddly-ness where the code duplication between
Envelope.hpp
andEnvelopeGate.hpp
is tiresome. Could think about pulling out the wholetest if finite and filter-twice-if-needed
saga into its own thing
I have satisfied @weefuzzy first 2 demands. clang-format revealed other discrepancies which I've pushed as we may as well clean it here. As much as I agree with the spirit of the 3rd request, I'd do a proper refactor of these 2 things to make them more efficient in block process (they are doing sample per sample now which is suboptimal) |
Don't think there's a way around that for these algorithms because they need per-sample feedback. But, in any case, is was the formatting consistency that was the thing here. I'd be inclined to go with this unless there's a clear functional reason to play with the other solution ahead of just fixing this bug. Feels to me like a we-can-revisit-if-it's-a-problem kind of thing. |
ok thanks both. Let's put that fix in and consider other options as future improvements |
check the input to env and envgate and stores the last valid value to replace non-finite values with