-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add templates #59
Conversation
fix: fluence run --dry
DXJ-141 Add templates
Add reasonable templates for ts, js Add default aqua input and output to fluence.yaml so there is no need to provide it Also don't ask for output on |
|
||
export const ensureFluenceJSDeployedAppPath = (fluenceJSDir: string): string => | ||
path.join(fluenceJSDir, DEPLOYED_APP_JS_FILE_NAME); | ||
export const ensureFluenceJSAppPath = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these paths configurable? I mean JS and TS destination paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
@@ -142,52 +160,52 @@ import "@fluencelabs/aqua-lib/builtin.aqua" | |||
|
|||
-- import App from "deployed.app.aqua" | |||
-- import Adder from "services/adder.aqua" | |||
-- export App, add_one | |||
-- export App, addOne |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are doing snake_case to camelCase renaming only for the sake of making generated TS files look nice than I think we are doing it in the wrong place. This should be done inside aqua compiler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like snake case. But I don't care much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think compiler shouldn't do that. It's just camelCase is a lot more popular among js developers so I think people who compile to js would prefer using camelCase themselves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our built-ins library is using snake case in function naming. So if a developer would be using camelCase they would inevitably face style inconsistencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge the changes if you need them ASAP. But I would suggest to come to some sort of an agreement on naming style and fix the aqua template accordingly.
I will merge this for now. If we decide something different - I will just do another PR with a fix |
fix: fluence run --dry