Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): improve error reporting when cannot run cargo #434

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

ValeryAntopol
Copy link
Collaborator

@ValeryAntopol ValeryAntopol commented May 31, 2024

Previously program that has not been found or the command arguments were not printed by marine cli. Now they are added:

$ marine build -p wasm-greeting
Error: cannot run `cargo`: executable not found in $PATH
$ marine build -p wasm-greeting
Error: cannot run `cargo`: Permission denied (os error 13)
$ marine build -p wasm-greeting
error: no such command: `buildd`

	Did you mean `build`?

	View all installed commands with `cargo --list`
	Find a package to install `buildd` with `cargo search cargo-buildd`
Error: command `cargo buildd --target wasm32-wasi --message-format json-render-diagnostics -p wasm-greeting` exited with exit status: 101

Copy link

@monoid monoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fluencebot fluencebot added the e2e Run e2e workflow label May 31, 2024
tools/cli/src/utils.rs Outdated Show resolved Hide resolved
@ValeryAntopol ValeryAntopol merged commit 0bb178a into master Jun 5, 2024
6 of 7 checks passed
@ValeryAntopol ValeryAntopol deleted the fix/cargo-not-found-error branch June 5, 2024 12:32
@fluencebot fluencebot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants