-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COM-12568: Replace pylint/black with ruff #208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdimopoulos
force-pushed
the
COM-12568
branch
7 times, most recently
from
November 25, 2024 15:50
f610304
to
de8ff86
Compare
mcesariniflu
reviewed
Dec 2, 2024
mcesariniflu
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one comment in fluster/main.py file in lines 351 and 352
mdimopoulos
force-pushed
the
COM-12568
branch
from
December 3, 2024 18:29
de8ff86
to
e121fff
Compare
mcesariniflu
approved these changes
Dec 4, 2024
rgonzalezfluendo
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blocking the PR
mdimopoulos
force-pushed
the
COM-12568
branch
from
December 4, 2024 10:54
e121fff
to
1f05de6
Compare
rgonzalezfluendo
approved these changes
Dec 4, 2024
- bumped python version from 3.6 to 3.7 - replaced pylint/black/flake8 in project configuration - renamed Makefile target lint to lint-check - added Makefile target lint which fixes issues with ruff - reformatted relevant files with ruff to prevent CI failure
- added folder "scripts" to Makefile path for checks - refactored .py files under scripts folder
- added pixel format discovery with ffprobe - added OutputFormat.YUV420P10LE to av1_aom decoder - updated AV1-TEST-VECTORS.json
mdimopoulos
force-pushed
the
COM-12568
branch
from
December 9, 2024 18:03
1f05de6
to
b5cb0ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.