Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM-12579-2-fix in adding changelog as notes #212

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

rsanchez87
Copy link
Contributor

fix in adding changelog as notes (include echo -e to file.txt) to avoid special characters issues

*fix in adding changelog as notes (include echo -e to file.txt) to avoid special characters issues.
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
When we create the changelog file in the future, we will modify the yml to read information from there.

*delete line (NOTES=${{ github.event.inputs.notes }})
*change env: order into create_release steps
@rsanchez87 rsanchez87 merged commit db77a8a into master Nov 19, 2024
7 checks passed
@rsanchez87 rsanchez87 deleted the COM-12579-2 branch November 19, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants