COM-12602-Replace erroneous h266 reference decoder in fluster: #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rsanchez87
commented
Nov 22, 2024
rsanchez87
commented
- add h266_reference_decoder (VVCSoftware_VTM-H266)
- maintain h266_vvdec_decoder (VVdeC, the Fraunhofer Versatile Video Decoder)
- update README.md
* add h266_reference_decoder (VVCSoftware_VTM-H266) * maintain h266_vvdec_decoder (VVdeC, the Fraunhofer Versatile Video Decoder) * update README.md
|
After testing with VVCSoftware_VTM-H266 new reference decoder, md5sum in
|
fluster/decoders/gstreamer.py
Outdated
| """GStreamer H.266/VVC VVCSoftware_VTM decoder implementation for GStreamer 1.0""" | ||
|
|
||
| codec = Codec.H266 | ||
| decoder_bin = " Decoder " |
There was a problem hiding this comment.
Which bin is this?
fluster/decoders/h266_vvdec.py
Outdated
| @@ -21,7 +21,7 @@ | |||
|
|
|||
|
|
|||
| @register_decoder | |||
| class H266JCTVTDecoder(Decoder): | |||
| class H266VVCDecoder(Decoder): | |||
| """VVdeC H.266/VVC reference decoder implementation""" | |||
There was a problem hiding this comment.
it is no reference:
Suggested change
| """VVdeC H.266/VVC reference decoder implementation""" | |
| """VVdeC H.266/VVC decoder implementation""" |
* remove vvc_vtm decoder from gstreamer.py * remove reference from vvc decoder * change authors in h266_vvc_vtm.py h266_vvdec.py decoders
fluster/decoders/h266_vvc_vtm.py
Outdated
|
|
||
| @register_decoder | ||
| class H266VVCVTMDecoder(Decoder): | ||
| """VVdeC H.266/VVC reference decoder implementation""" |
There was a problem hiding this comment.
it is not VVdeC. It is VTM.
rgonzalezfluendo
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.