Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM-12464 - MPEG-4 AAC mp4 #219

Merged
merged 1 commit into from
Dec 9, 2024
Merged

COM-12464 - MPEG-4 AAC mp4 #219

merged 1 commit into from
Dec 9, 2024

Conversation

mcesariniflu
Copy link
Contributor

MPEG-4 AAC mp4
modified: scripts/gen_aac.py

  • Modified Regex for MPEG2_AAC_ADIF
  • Different parsers were added, one for each kind of file (compressed, raw and checksum)
  • DVD3 Wav files were added
  • Validation logic for audio files was added

@mcesariniflu mcesariniflu changed the title MPEG-4 AAC mp4 - On branch COM-12464 COM-12464 - MPEG-4 AAC mp4 Dec 2, 2024
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested, check individual comments and let me know if any doubt

scripts/gen_aac.py Outdated Show resolved Hide resolved
scripts/gen_aac.py Outdated Show resolved Hide resolved
scripts/gen_aac.py Show resolved Hide resolved
scripts/gen_aac.py Outdated Show resolved Hide resolved
scripts/gen_aac.py Outdated Show resolved Hide resolved
scripts/gen_aac.py Outdated Show resolved Hide resolved
scripts/gen_aac.py Outdated Show resolved Hide resolved
scripts/gen_aac.py Outdated Show resolved Hide resolved
scripts/gen_aac.py Outdated Show resolved Hide resolved
scripts/gen_aac.py Outdated Show resolved Hide resolved
scripts/gen_aac.py Outdated Show resolved Hide resolved
	modified:   scripts/gen_aac.py
- Modified regex for MPEG2_AAC_ADIF
- Different hparsers were added for each file type
- Wav files were added from DVD3
- Audio files validation logic was added
@mcesariniflu mcesariniflu merged commit a9b68ca into master Dec 9, 2024
3 checks passed
@mcesariniflu mcesariniflu deleted the COM-12464 branch December 9, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants