COM-12646: Remove .wav and .md5 code from AAC test suite generator #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile
Outdated
| if ! dpkg -l | grep gcc-multilib -c >>/dev/null; then sudo apt-get install gcc-multilib; fi | ||
| if ! dpkg -l | grep g++-multilib -c >>/dev/null; then sudo apt-get install g++-multilib; fi | ||
| ifeq ($(KERNEL_NAME), Linux) | ||
| if ! dpkg -l | grep gcc-multilib -c >>/dev/null; then sudo apt-get install gcc-multilib; fi && true |
There was a problem hiding this comment.
Why && true? or why not also in mpeg_4_aac_reference_decoder?
There was a problem hiding this comment.
Thanks for the feedback. I need to remove && true because i added the ifeq
mdimopoulos
force-pushed
the
COM-12646
branch
from
44bf1a3 to
c28e9f4
Compare
mcesariniflu
approved these changes
Dec 18, 2024
- Replaced md5 expected checksums of .wav reference files with .pcm output of reference decoders - Many expected checksums are empty due to decoding failure of reference decoder with those test vectors
mcesariniflu
force-pushed
the
COM-12646
branch
from
c28e9f4 to
e55488c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.