Fix ffmpeg 7 compatibility #1265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it break with the older versions after this PR or would it support both? |
|
My code works on both |
|
Made a patch for this. You can download and use it by placing it in a folder called "patches" in your project and running |
|
@MarianoFacundoArch can you please revert style changes in |
renmu123
approved these changes
May 17, 2024
|
@MarianoFacundoArch could you revert the style changes please? It makes the PR very difficult to review and folks could use this update. Fwiw, I tried downloading your package fluent-ffmpeg-7 and ran into the same issues. |
|
@govindrai If you want a fix now, try the patch file I attached above. |
totallytavi
added a commit
to totallytavi/node-fluent-ffmpeg
that referenced
this pull request
May 19, 2024
* Add capture for all whitespace * Change copied from fluent-ffmpeg#1265, minus the style changes
|
Replaced by #1274 |
topcraft320
added a commit
to topcraft320/node-fluent-ffmpeg
that referenced
this pull request
Aug 3, 2024
* Add capture for all whitespace * Change copied from fluent-ffmpeg/node-fluent-ffmpeg#1265, minus the style changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.