Kill ffmpeg process when outputs stream closes #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is handy for cases like streaming through express, where the process might go on for a long time and the output connection can be killed.
schaermu
added a commit
that referenced
this pull request
Oct 4, 2012
Kill ffmpeg process when outputs stream closes
|
Good stuff, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice if you use the express-stream sample & you kill the stream part way (say, close the browser tab mid video) the ffmpeg process keeps running until its done, or the timeout is hit.
This change proactively kills the ffmpeg proc when the output stream fires "close".