monitoring.md: Add input Tail plugin metrics to monitoring page#2380
monitoring.md: Add input Tail plugin metrics to monitoring page#2380c-neto wants to merge 1 commit intofluent:masterfrom
monitoring.md: Add input Tail plugin metrics to monitoring page#2380Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughAdds documentation for six Tail input plugin metrics (files_closed, files_opened, files_rotated, long_line_skipped, long_line_truncated, multiline_truncated) to monitoring docs and adds a reference to those metrics in the Tail input plugin documentation. No code or behavioral changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@administration/monitoring.md`:
- Line 236: The section heading "Tail Input Plugin Metrics" uses title-style
capitalization; change it to sentence-style by editing the heading text to "Tail
input plugin metrics" in the documentation (look for the heading string "Tail
Input Plugin Metrics") so only the first word is capitalized and the rest are
lowercased as appropriate.
- Line 247: Update the metric description for
fluentbit_input_multiline_truncated_total to fix typos: change “occurences” to
“occurrences” and “multilines” to “multiline” so the description reads something
like “Total number of truncated occurrences for multiline. This metric is only
created when `multiline.parser` is defined.” Ensure you modify the line
containing the metric name `fluentbit_input_multiline_truncated_total` in
monitoring.md.
In `@pipeline/inputs/tail.md`:
- Around line 573-575: The heading "### Input Tail Metrics" uses title-style
capitalization; change it to sentence-style capitalization by updating the
heading text (look for the literal "### Input Tail Metrics") to "### Input tail
metrics" so only the first word is capitalized and plugin name is lowercased per
house style.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pipeline/inputs/tail.md`:
- Around line 573-575: The markdown under the "Input tail metrics" section uses
an absolute link to /administration/monitoring.md which can break site routing;
update the link to the relative path used elsewhere in this doc (e.g.,
../../administration/monitoring.md) so the sentence "For detailed information
about available metrics and how to use them, see [Monitoring](...)." points to
the relative location instead of the absolute root.
Signed-off-by: Carlos Neto <carlos.neto.dev@gmail.com> docs: add metrics for Tail Input Plugin in monitoring documentation docs: correct capitalization and typos in Tail input plugin metrics section Signed-off-by: Carlos Neto <carlos.neto.dev@gmail.com> docs: update heading capitalization in Tail input metrics section Signed-off-by: Carlos Neto <carlos.neto.dev@gmail.com> docs: fix links to Tail input plugin documentation in monitoring and tail metrics sections Signed-off-by: Carlos Neto <carlos.neto.dev@gmail.com>
|
Hi @c-neto, Thanks for the fixes you are suggesting here. I have unfortunately just before you sent these submitted a rather comprehensive update to the Monitoring doc page. The changes you propose I have pulled into that PR and tagged it as fixing this issue, so once it merges, it should close this out for you. I will be marking your doc PR here as duplicate, to save us both time as the location you wanted to add them is I believe incorrect. I have added them into the existing table in this PR #2378 while giving you named credit for the help in the commit. I have cross-posted this to your original issue. |
This PR closes the following Issue:
monitoring.md: Add input Tail plugin metrics to monitoring page #2379Summary by CodeRabbit