out_cloudwatch_logs: add record_accessor support for log group and st… #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
krispraws
reviewed
Jun 30, 2022
pipeline/outputs/cloudwatch.md
Outdated
| @@ -18,8 +18,10 @@ See [here](https://github.com/fluent/fluent-bit-docs/tree/43c4fe134611da471e706b | |||
| | ------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| | region | The AWS region. | | |||
| | log_group_name | The name of the CloudWatch Log Group that you want log records sent to. | | |||
| | log_group_template | Template for Log Group name using Fluent Bit [record_accessor](https://docs.fluentbit.io/manual/administration/configuring-fluent-bit/classic-mode/record-accessor) syntax. If the template translation fails an error is logged and the log_stream_name or log_stream_prefix are used instead. See the tutorial below for an example. | | |||
There was a problem hiding this comment.
Should the documentation mention that the field is optional, and that it overrides the log_group_name if present?
Nit: Missing comma after If the template translation fails
pipeline/outputs/cloudwatch.md
Outdated
| | log_stream_name | The name of the CloudWatch Log Stream that you want log records sent to. | | ||
| | log_stream_prefix | Prefix for the Log Stream name. The tag is appended to the prefix to construct the full log stream name. Not compatible with the log_stream_name option. | | ||
| | log_stream_template | Template for Log Stream name using Fluent Bit [record_accessor](https://docs.fluentbit.io/manual/administration/configuring-fluent-bit/classic-mode/record-accessor) syntax. If the template translation fails an error is logged and the log_stream_name or log_stream_prefix are used instead. See the tutorial below for an example. | |
pipeline/outputs/cloudwatch.md
Outdated
|
|
||
| Here is an example usage, for a common use case- templating log group and stream names based on Kubernetes metadata. | ||
|
|
||
| Recall that the kubernetes filter can add metadata if you run Fluent Bit in kubernetes that will look like the following: |
|
@PettitWesley can we get this updated and merged? A user had an issue in Slack that was resolved after finding this in the code so be good to document it. |
…ream name templating Signed-off-by: Wesley Pettit <wppttt@amazon.com>
PettitWesley
force-pushed
the
cw-record-accessor
branch
from
f5fa8c4 to
77bdb92
Compare
|
@patrick-stephens thanks for reminding me, had forgotten about this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ream name templating
Signed-off-by: Wesley Pettit wppttt@amazon.com