-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks #69
base: master
Are you sure you want to change the base?
Tweaks #69
Conversation
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
@@ -1,5 +1,5 @@ | |||
module github.com/fluent/fluent-bit-go | |||
|
|||
go 1.14 | |||
go 1.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't bump the Go version until it's necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow DCO. We don’t merge PR without following DCO procedure.
Could you add your test data as binary arrays instead of adding binary files? Adding binary files leads to decrease maintainability for test cases.
@cosmo0920 Thanks for the work on fluent-bit-go
I made a little branch with a couple of other minor tweaks.
Dump go version, and update the dependency
go 1.20
github.com/ugorji/go/codec
Verify timestamp without reflection
To verify the timestamp is being decoded correctly added a extractTimeStamp() function to extract the time without using reflection.
More test data
Also tried to add another test input, and this actually fails. I believe the input data is valid, because I extracted it from my running version of fluentbit. Have I just made a coding error, or has it found a real issue? I added some log lines, and the input data looks ok-ish.
`das@t:~/Downloads/fluent-bit-go/output$ ~/Downloads/msgpack-inspect ./testdata/data | more
header: "0xdd"
length: 2
children:
header: "0xdd"
length: 2
children:
header: "0xd7"
exttype: 0
length: 8
data: "0x64b579fd24b76a00"
header: "0x80"
length: 0
children: []
header: "0xde"
length: 43
children:
format: "fixstr"
header: "0xa4"
length: 4`
Thanks in advance