Windows containers failing to build

[patrick-stephens]

Windows 2019 failed here https://github.com/fluent/fluent-bit/actions/runs/14178178470/job/39718022548#step:5:2710 because that plugin uses flb_plg_trace which in turn uses FLB_FILENAME which apparently is not defined in this environment.

@leonardo-albertovich thinks the root cause of it is we're adding the definition in the global CMakeLists.txt file here using the gcc/clang compatible command line flag unconditionally instad of doing it in the previous conditional where we could use /D__FLB_FILENAME__=FILE for msvc and -D__FLB_FILENAME__=FILE for the rest.

[mabrarov]

Hi @patrick-stephens,

By some reason when using NMake Makefiles CMake generator (I can be wrong, but I feel it was documentation recommended way of building Fluent Bit on Windows 1-2 years ago), then this issue doesn't happen. Refer to #10180.

IMHO, Fluent Bit CMake project (including its sub-projects) can be not ready for CMake multi-configuration generators (as opposite to single-configuration generators). Such CMake generators require usage of CMake generator expressions - refer to https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#build-configurations.

Thank you.

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

[github-actions]

This issue was closed because it has been stalled for 5 days with no activity.

[mabrarov]

Hi @patrick-stephens,

This issue is fixed in #11397. The issue is not caused by - used instead of /, but is caused by enabling C++ language support (introduced in #9468) in CMake project after some of CMAKE_CXX_* variables were inspected / modified (extended). As far as I understand from this issue, we should either add CXX into project command of root CMakeLists.txt (as well as C, we can also omit languages in project and rely on By default C and CXX are enabled if no language options are given) or use (read/modify) CMAKE_CXX_* CMake variables only after C++ language support is enabled (enable_language(CXX)). Otherwise C++ projects get wrong compiler / linker options (it looks to happen only with some of CMake Generators, maybe with multi-config ones which "Visual Studio" generators are).

Thank you.