Skip to content

dockerfile: Enable default SIMD support in Docker #10225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jinyongchoi
Copy link
Contributor

@jinyongchoi jinyongchoi commented Apr 17, 2025

According to the documentation,
SIMD is supposed to be enabled by default in Fluent Bit container images.

This commit updates the Dockerfile to reflect that, enabling SIMD by default.

Closes #10215


Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@jinyongchoi jinyongchoi force-pushed the 10215-enable_simd_in_container branch 2 times, most recently from 12620cb to 06d8967 Compare April 17, 2025 10:46
@jinyongchoi
Copy link
Contributor Author

I think it makes sense to wait until this ticket(#10178) is completed before proceeding.
I’ll hold off for now.

@cdancy
Copy link

cdancy commented Apr 29, 2025

@jinyongchoi looks like those PR's were merged. Can we move forward here as we'd love to have a boost in json processing as well.

@jinyongchoi jinyongchoi force-pushed the 10215-enable_simd_in_container branch from 3a7abc0 to 662ba6b Compare April 30, 2025 07:14
@jinyongchoi jinyongchoi force-pushed the 10215-enable_simd_in_container branch from 662ba6b to 3d5e883 Compare April 30, 2025 07:16
@jinyongchoi jinyongchoi force-pushed the 10215-enable_simd_in_container branch from 3d5e883 to ed5d9e0 Compare April 30, 2025 12:36
@jinyongchoi jinyongchoi force-pushed the 10215-enable_simd_in_container branch from ed5d9e0 to 07b6cac Compare April 30, 2025 12:53
@jinyongchoi
Copy link
Contributor Author

@patrick-stephens @cdancy Hello,
I've enabled the FLB_SIMD option by default in all Dockerfiles except for Dockerfile.centos7,
which is used for internal testing.
If the SIMD option should also be enabled there, please let me know and I’ll update it accordingly.
Thank you!

According to the documentation,
SIMD is supposed to be enabled by default in Fluent Bit container images.

This commit updates the Dockerfile to reflect that, enabling SIMD by default.

Signed-off-by: jinyong.choi <inimax801@gmail.com>
@jinyongchoi
Copy link
Contributor Author

@patrick-stephens Added Alma and Rocky. Let me know if anything else is needed!

@jinyongchoi
Copy link
Contributor Author

Hi~ @edsiper, This should be ready for review now.
Let me know if there's anything else you'd like me to change.

@patrick-stephens patrick-stephens changed the title dockerfile: Enable default SIMD support in Docker (#10215) dockerfile: Enable default SIMD support in Docker Jun 30, 2025
@patrick-stephens patrick-stephens merged commit f3afefb into fluent:master Jun 30, 2025
74 checks passed
@pawelrubin
Copy link

Hi @patrick-stephens, Thank you for your work on this PR. We are looking forward to this change and were wondering if there's an estimated release date for it. Could you also let us know if it's being considered for inclusion in a future Fluent Bit 3.2.x release?

@patrick-stephens
Copy link
Contributor

patrick-stephens commented Jul 2, 2025

It'll be in the next 4.x release, probably next week or so.

To get it in a 3.2 release it needs backporting to the 3.2 branch but I doubt it'll go into a release there unless someone pushes for it and makes the PR. 3.2 is really only getting critical fixes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-package-test Run PR packaging tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using SIMD in a Fluent Bit Container
5 participants