-
Notifications
You must be signed in to change notification settings - Fork 1.7k
dockerfile: Enable default SIMD support in Docker #10225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerfile: Enable default SIMD support in Docker #10225
Conversation
12620cb
to
06d8967
Compare
I think it makes sense to wait until this ticket(#10178) is completed before proceeding. |
@jinyongchoi looks like those PR's were merged. Can we move forward here as we'd love to have a boost in json processing as well. |
3a7abc0
to
662ba6b
Compare
662ba6b
to
3d5e883
Compare
3d5e883
to
ed5d9e0
Compare
ed5d9e0
to
07b6cac
Compare
@patrick-stephens @cdancy Hello, |
e487541
to
eb970ea
Compare
eb970ea
to
14fd6dc
Compare
According to the documentation, SIMD is supposed to be enabled by default in Fluent Bit container images. This commit updates the Dockerfile to reflect that, enabling SIMD by default. Signed-off-by: jinyong.choi <inimax801@gmail.com>
14fd6dc
to
5d3b358
Compare
@patrick-stephens Added Alma and Rocky. Let me know if anything else is needed! |
Hi~ @edsiper, This should be ready for review now. |
Hi @patrick-stephens, Thank you for your work on this PR. We are looking forward to this change and were wondering if there's an estimated release date for it. Could you also let us know if it's being considered for inclusion in a future Fluent Bit 3.2.x release? |
It'll be in the next 4.x release, probably next week or so. To get it in a 3.2 release it needs backporting to the 3.2 branch but I doubt it'll go into a release there unless someone pushes for it and makes the PR. 3.2 is really only getting critical fixes now. |
According to the documentation,
SIMD is supposed to be enabled by default in Fluent Bit container images.
This commit updates the Dockerfile to reflect that, enabling SIMD by default.
Closes #10215
Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.