-
Notifications
You must be signed in to change notification settings - Fork 1.7k
out_cloudwatch_logs: Added StorageResolution support for EMF #10398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
out_cloudwatch_logs: Added StorageResolution support for EMF #10398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This StorageResolution parameter is already supported for the metrics type of pipelines. So, it'll be only effective for logs type of pipelines which contain cpu or mem plugin.
if (tmp) | ||
{ | ||
flb_plg_info(ctx->ins, "Metric Storage Resolution=%s", tmp); | ||
ctx->metric_storage_resolution = atoi(tmp); | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines could be violated for the coding guide line:
https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#coding-style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated formatting.
And correct. As cpu and mem are not considered metrics, this will only apply to them. May be outside the scope of this PR but does bring up the issue of whether cpu and mem should be updated to be metrics or kept as logs.
ping @sparrc @singholt @swapneils |
Signed-off-by: Devin Stafford <devin@andrenam.com>
4cfca0c
to
cd82c37
Compare
The following PR adds support for StorageResolution for CloudWatch metrics. This tunable allows users to indicate to CloudWatch the expected granularity to store the metrics. See the following CloudWatch documentation for details.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
The following images illustrate the correctness of the raw EMF logs as well as its sub 60s resolution at the metric graphing level.


If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Documentation PR
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.