in_winevtlog: Handle Daylight saving time by using newer functions#10628
Merged
in_winevtlog: Handle Daylight saving time by using newer functions#10628
Conversation
* SystemTimeToTzSpecificLocalTimeEx * GetDynamicTimeZoneInformation are able to handle Daylight Saving Time(DST). Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
FileTimeToLocalFileTime and SystemTimeToTzSpecificLocalTimeEx automatically convert between ST and DST. These functions are working well for DST conversions. Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
1 task
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
are able to handle Daylight Saving Time(DST).
FileTimeToLocalFileTime and SystemTimeToTzSpecificLocalTimeEx
automatically convert between ST and DST.
These functions are working well for DST conversions.
Then, we got:
PST is now under Daylight Saving Time(DST).
So, it's correct behavior for the DST implemented timezone.
This was originally reported in #8386.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
It's easily testing with the basic winevtlog plugin's parameters.
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.