Skip to content

Comments

opentelemetry: allow empty strings for TraceID and SpanID (logs) [Backport to 4.0]#10962

Merged
cosmo0920 merged 2 commits into4.0from
in_opentelemetry_empty_trace_span-4.0
Oct 2, 2025
Merged

opentelemetry: allow empty strings for TraceID and SpanID (logs) [Backport to 4.0]#10962
cosmo0920 merged 2 commits into4.0from
in_opentelemetry_empty_trace_span-4.0

Conversation

@cosmo0920
Copy link
Contributor

Backporting of #10956.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
@coderabbitai
Copy link

coderabbitai bot commented Oct 2, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch in_opentelemetry_empty_trace_span-4.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cosmo0920 cosmo0920 merged commit 48afea2 into 4.0 Oct 2, 2025
54 of 55 checks passed
@cosmo0920 cosmo0920 deleted the in_opentelemetry_empty_trace_span-4.0 branch October 2, 2025 09:24
@niedbalski
Copy link
Contributor

🔄 Backported to FluentDo Agent

This change has been backported to FluentDo Agent.

You can view the test results and integration status in the FluentDo Agent PR.


This is an automated notification from FluentDo Agent's backport tracking system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants