Skip to content

Conversation

@cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Jan 8, 2026


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Chores
    • Updated the unit-tests workflow to include the 4.2 branch, ensuring automated testing runs for this branch on push events.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@coderabbitai
Copy link

coderabbitai bot commented Jan 8, 2026

📝 Walkthrough

Walkthrough

The pull request adds the 4.2 release branch to the push trigger conditions in the unit-tests GitHub Actions workflow. This expands the list of branches that automatically execute unit tests when code is pushed, ensuring the 4.2 branch receives automated testing.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
\.github/workflows/unit-tests.yaml``
Added 4.2 branch to the push trigger event, enabling automated unit test execution for the 4.2 release branch

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly Related PRs

Suggested Labels

docs-required

Suggested Reviewers

  • niedbalski
  • patrick-stephens
  • celalettin1286

Poem

🐰 A branch hops forward, 4.2 takes its place,
Tests will now run with swift grace,
Simple yet vital, the workflow expands,
Automation takes the testing commands! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding the 4.2 branch to the unit-tests workflow for automated test processing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e19e07e and 9b70392.

📒 Files selected for processing (1)
  • .github/workflows/unit-tests.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/unit-tests.yaml (1)

3-36: Add 4.2, 4.1, and 4.0 to the push trigger.

The push trigger only includes branches up to 3.2, while the pull_request trigger includes 4.2, 4.1, and 4.0. This means unit tests run for pull requests targeting these branches but not for direct pushes to them. Since 4.2, 4.1, and 4.0 are active release branches in the repository, they should be included in the push trigger as well for consistency and to ensure tests run on all commits to these production branches.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e19e07e and 9b70392.

📒 Files selected for processing (1)
  • .github/workflows/unit-tests.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants