-
Notifications
You must be signed in to change notification settings - Fork 1.9k
http: default HTTP User-Agent header with version information #11434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
endersonmaia
wants to merge
34
commits into
fluent:master
Choose a base branch
from
endersonmaia:feat/add-http-agent-header
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
da84de9
http_client: add version and git hash to default User-Agent header
endersonmaia 88dd93e
aws: use standardized User-Agent header with version info
endersonmaia 23354a3
tests: update http_client test for new User-Agent header
endersonmaia 6d172fb
filter_ecs: use standardized User-Agent header with version info
endersonmaia 8eb6eaa
filter_kubernetes: use standardized User-Agent header with version info
endersonmaia 60843d2
filter_nightfall: use standardized User-Agent header with version info
endersonmaia ae82787
in_calyptia_fleet: use standardized User-Agent header with version info
endersonmaia 463f72d
in_kubernetes_events: use standardized User-Agent header with version…
endersonmaia 47dd194
in_nginx_exporter_metrics: use standardized User-Agent header with ve…
endersonmaia d6f14ac
in_prometheus_scrape: use standardized User-Agent header with version…
endersonmaia 72a7fb1
out_azure: use standardized User-Agent header with version info
endersonmaia e8b147a
out_azure_blob: use standardized User-Agent header with version info
endersonmaia 26f331d
out_azure_kusto: use standardized User-Agent header with version info
endersonmaia a6f6d1a
out_azure_logs_ingestion: use standardized User-Agent header with ver…
endersonmaia 98d72f5
out_bigquery: use standardized User-Agent header with version info
endersonmaia f78d3df
out_chronicle: use standardized User-Agent header with version info
endersonmaia 777a8f9
out_datadog: use standardized User-Agent header with version info
endersonmaia dfb87d6
out_es: use standardized User-Agent header with version info
endersonmaia fc6e68f
out_http: use standardized User-Agent header with version info
endersonmaia 3a10b00
out_influxdb: use standardized User-Agent header with version info
endersonmaia d988ee6
out_kafka_rest: use standardized User-Agent header with version info
endersonmaia d2447b0
out_logdna: use standardized User-Agent header with version info
endersonmaia a9fce80
out_loki: use standardized User-Agent header with version info
endersonmaia 75f7a17
out_nrlogs: use standardized User-Agent header with version info
endersonmaia d49970a
out_opensearch: use standardized User-Agent header with version info
endersonmaia f3acd33
out_opentelemetry: use standardized User-Agent header with version info
endersonmaia dd5bbcc
out_prometheus_remote_write: use standardized User-Agent header
endersonmaia cfd4f63
out_s3: use standardized User-Agent header with version info
endersonmaia 9d70d7d
out_skywalking: use standardized User-Agent header with version info
endersonmaia e0e2e1b
out_slack: use standardized User-Agent header with version info
endersonmaia bd65e75
out_splunk: use standardized User-Agent header with version info
endersonmaia 91ad547
out_stackdriver: use standardized User-Agent header with version info
endersonmaia dc60b54
out_td: use standardized User-Agent header with version info
endersonmaia e90dcce
out_websocket: use standardized User-Agent header with version info
endersonmaia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the return value to avoid silently skipping the User-Agent.
If
flb_http_add_headerfails (e.g., allocation failure), the request proceeds without the header, which can reintroduce the 418 behavior this PR aims to fix. Consider aborting the request on failure.Suggested fix
📝 Committable suggestion
🧰 Tools
🪛 Cppcheck (2.19.0)
[error] 140-140: There is an unknown macro here somewhere. Configuration is required. If FLB_VERSION_STR is a macro then please configure it.
(unknownMacro)
🤖 Prompt for AI Agents