Skip to content

processor_sampling: perf improvement in tail sampling reconciliation #11441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edsiper merged 5 commits into from
Feb 10, 2026
Merged

processor_sampling: perf improvement in tail sampling reconciliation #11441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a2e46c4
benchmarks: add processor_sampling
edsiper Feb 9, 2026
c30d4f0
processor_sampling: add legacy/optimized tail reconcile switch and A/…
edsiper Feb 9, 2026
c9a3769
github: scripts: adjust commit prefix checker for benchmarks
edsiper Feb 9, 2026
016c4e9
benchmarks: processor_sampling: add guards for zero spans
edsiper Feb 9, 2026
70bba47
github: scripts: fix commit prefix extraction capture in linter
edsiper Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/scripts/commit_prefix_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
repo = Repo(".")

# Regex patterns
PREFIX_RE = re.compile(r"^[a-z0-9_]+:", re.IGNORECASE)
PREFIX_RE = re.compile(r"^([a-z0-9_]+:)\s+\S", re.IGNORECASE)
SIGNED_OFF_RE = re.compile(r"Signed-off-by:", re.IGNORECASE)
FENCED_BLOCK_RE = re.compile(
r"""
Expand Down Expand Up @@ -86,6 +86,10 @@ def infer_prefix_from_paths(paths):
if len(parts) > 1:
component_prefixes.add(f"{parts[1]}:")

# ----- benchmarks/ → benchmarks: -----
if p.startswith("benchmarks/"):
component_prefixes.add("benchmarks:")

# ----- src/ → flb_xxx.* → xxx: OR src/<dir>/ → <dir>: -----
# ----- src/ handling -----
if p.startswith("src/"):
Expand Down Expand Up @@ -172,7 +176,7 @@ def validate_commit(commit):
if not subject_prefix_match:
return False, f"Missing prefix in commit subject: '{first_line}'"

subject_prefix = subject_prefix_match.group()
subject_prefix = subject_prefix_match.group(1)

# Run squash detection (but ignore multi-signoff errors)
bad_squash, reason = detect_bad_squash(body)
Expand Down
13 changes: 13 additions & 0 deletions benchmarks/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,16 @@ target_link_libraries(flb-bench-pack_json
${CMAKE_THREAD_LIBS_INIT}
)

add_executable(flb-bench-processor_sampling
flb-bench-processor_sampling.c
../plugins/processor_sampling/sampling_probabilistic.c
../plugins/processor_sampling/sampling_span_registry.c
../plugins/processor_sampling/sampling_tail.c
)
target_compile_definitions(flb-bench-processor_sampling
PRIVATE FLB_SAMPLING_BENCH=1
)
target_link_libraries(flb-bench-processor_sampling
fluent-bit-static
${CMAKE_THREAD_LIBS_INIT}
)
Loading
Loading