parser: fix segmentation fault on "Types" option #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas Heggelund reported a segmentation fault issue on the "Types"
option. His configuration was:
[PARSER]
Name dips-log4net-multiline
Format regex
Regex ^(?<test>.*)$
Types test:integer
It turned out that c197f1c introduced a new method get_parser_key()
but forgot to apply that change to some option.
Due to this inconsistency, it ended up calling flb_sds_destroy() on a
plain char*. Resolve that issue by fixing the inconsistent key
retrieval.
Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thomas Heggelund reported a segmentation fault issue on the "Types"
option. His configuration was:
It turned out that c197f1c introduced a new method get_parser_key()
but forgot to apply that change to some option.
Due to this inconsistency, it ended up calling flb_sds_destroy() on a
plain char*. Resolve that issue by fixing the inconsistent key
retrieval.
Signed-off-by: Fujimoto Seiji fujimoto@ceptord.net