out_cloudwatch_logs: Rename 'event' to 'cw_event' #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libevent exports a struct with the same name (`struct event` in event2/event_struct.h). For this reason, this plugin fails to compile if libevent backend is enabled. Also unistd.h is not POSIX standard and not all platforms (in particular Windows) do not provide it. Include flb_compat.h to abstract away the header inclusion. With this patch, I can confirm out_cloudwatch_logs can be compiled and run on Windows. Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
|
CC: @PettitWesley Addendum: This patch makes Windows CI green again |
fujimotos
force-pushed
the
sf/win32-cloudwatch
branch
from
b98ae48
to
790ddf7
Compare
PettitWesley
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libevent exports a struct with the same name (
struct eventinevent2/event_struct.h). For this reason, this plugin fails to
compile if libevent backend is enabled.
Also unistd.h is not POSIX standard and not all platforms (in
particular Windows) do not provide it. Include flb_compat.h to
abstract away the header inclusion.
With this patch, I can confirm out_cloudwatch_logs can be compiled
and run on Windows.
Signed-off-by: Fujimoto Seiji fujimoto@ceptord.net