http_client: mark connection as non-reuseable on failure #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flb_http_client supports internal buffer size limit. If server
tries to send more data than the maximum size limit, the client
will refuse to receive it.
This behaviour is problematic when combined with keep-alive mode;
Since flb_http_do() can leave some data in the socket, the next
HTTP request can be confused by the leftover.
For example, if the socket has the following data (unread):
"data":["from", "previous", "conn"]}
The next HTTP request will see the following response:
"data":["from", "previous", "conn"]}HTTP/1.1 200 OK
Content-Type: text/html
Accept-Ranges: bytes
Last-Modified: Sat, 30 May 2020 23:47:16 GMT
...
Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flb_http_client supports internal buffer size limit. If server
tries to send more data than the maximum size limit, the client
will refuse to receive it.
This behaviour is problematic when combined with keep-alive mode;
Since flb_http_do() can leave some data in the socket, the next
HTTP request can be confused by the leftover.
For example, if the socket has the following data (unread):
The next HTTP request will see the following response:
This bug is originally reported by @gitfool on #960 (comment).
Signed-off-by: Fujimoto Seiji fujimoto@ceptord.net