core: cast variables to avoid fpermissive errors #7456
Conversation
Minipada
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
|
PS: I noticed this being printed now Was it intentional? |
include/fluent-bit/flb_input.h
Outdated
| if (params == NULL) { | ||
| params = flb_calloc(1, sizeof(struct flb_libco_in_params)); | ||
| params = (struct flb_libco_in_params *) flb_calloc(1, sizeof(struct flb_libco_in_params)); |
There was a problem hiding this comment.
Could you please break this and other lines that exceed the 80 column limit?
There was a problem hiding this comment.
Hi, I just pushed some changes. I am not sure if I needed the backslash before the newline but it compiles.
|
Thanks a lot for the contribution! As for that monkey message, that was definitively not intentional. It seems like I missed that debug artifact but I'll open a PR to remove it now. Thank you for pointing it out! |
| @@ -695,7 +695,7 @@ struct flb_output_flush *flb_output_flush_create(struct flb_task *task, | |||
| if ((serialization_buffer_offset + | |||
| serialized_context_size) > p_size) { | |||
| resized_serialization_buffer = \ | |||
| flb_realloc(p_buf, p_size + serialized_context_size); | |||
| (char*) flb_realloc(p_buf, p_size + serialized_context_size); | |||
There was a problem hiding this comment.
I am not sure how I could do less than 80 chars here so i did not touch
Signed-off-by: David Bensoussan <d.bensoussan@proton.me>
Minipada
changed the title
|
So, I was quite confused about this test result and I have the same result on my pc, also with the master branch... My system: Ubuntu 22.04 Commands: export CC=/usr/bin/clang
export CXX=/usr/bin/clang++
cmake -DFLB_TESTS_INTERNAL=On -DFLB_TESTS_RUNTIME=On -DFLB_EXAMPLES=Off -DFLB_OUT_PGSQL=On -DFLB_SHARED_LIB=On -DFLB_PROXY_GO=On -DSYSTEMD_UNITDIR=/usr/lib/systemd/system -DSANITIZE_ADDRESS=On ..
make -jCould you confirm this is an upstream bug? |
|
Which test result? |
|
Sorry, the one failing in CI: https://github.com/fluent/fluent-bit/actions/runs/5055636573/jobs/9077785996?pr=7456 I tried locally with: |
|
From what I can see in that log it doesn't sound like it's related to your PR but we should test master at head and the previous tags so we find the offending PR and fix it. I won't be able to do that today but it would be really helpful if you tested those. |
|
Sorry if I was not clear but I already ran the test and it failed on master :/ |
|
Yes, I expected it to fail on master, I wanted to get to the bottom of it but I guess it doesn't really matter for this PR. |
|
Is there anything else blocking to move forward with this PR? |
|
Not on my side, I have already approved it and @edsiper will probably merge it within the next release cycle. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
While using the C API for another project, I encountered some -permissive errors.
To simply put it, some statements should be casted and this is what I did in this PR.
errors:
Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.