Skip to content

cpack: add apt package manager prerm script #8330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

cpack: add apt package manager prerm script #8330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c4447a
add - add prerm script for apt
Dec 26, 2023
6e31d48
change - add disable for removing symbolic link before removal
Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,6 +1208,7 @@ if(DPKG_PROGRAM)
set(CPACK_DEBIAN_RUNTIME_FILE_NAME "${CPACK_PACKAGE_NAME}_${CPACK_PACKAGE_VERSION}_${CPACK_DEBIAN_PACKAGE_ARCHITECTURE}.deb")
set(CPACK_DEBIAN_RUNTIME_PACKAGE_CONTROL_EXTRA
${PROJECT_SOURCE_DIR}/cpack/debian/conffiles
${PROJECT_SOURCE_DIR}/cpack/debian/prerm
)

if(FLB_RUN_LDCONFIG)
Expand Down
12 changes: 12 additions & 0 deletions cpack/debian/prerm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/bin/bash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/bin/bash
#!/bin/sh


set -e

if [[ $1 == "remove" ]]; then
systemctl stop fluent-bit.service || true
systemctl disable fluent-bit.service || true
Comment on lines +6 to +7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we check whether service or systemctl command is effective on the Debian box?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I will test it on Debian 11 and 12 and reply back with results.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests have been successfully done on debian bullseye and bookworm versions.
After Debian 8 systemd is the default init system for debian (Debian Reference) so systemctl would not make any issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great. So, we shouldn't consider the outdated Debian system. Let's leave as-is.

else
echo "Unknown Argument! $1" || false
fi

exit 0