Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_sqldb : Removed db shared check through shared member valriable #9383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lchoudhu-tibco
Copy link

While initializing the db handlers , there is check db_temp->shared == TRUE .
However the check does not see if the db name is same for the stanzas or not , It just checks the 1st DB where shared is true and skips the rest check .
Let's consider 2 different configurations .

[INPUT]
name tail
path /mnt/a.log
db /mnt/a.db
storage.type filesystem
[INPUT]
name tail
path /mnt/b.log
db /mnt/a.db
storage.type filesystem
[INPUT]
name tail
path /mnt/c.log
db /mnt/c.db
storage.type filesystem

Expectation
2 databases should be created in sqlite3 , but 1 database is created -- a

[INPUT]
name tail
path /mnt/a.log
db /mnt/a.db
storage.type filesystem
[INPUT]
name tail
path /mnt/b.log
db /mnt/b.db
storage.type filesystem
[INPUT]
name tail
path /mnt/c.log
db /mnt/a.db
storage.type filesystem

Expectation
2 databases should be created in sqlite3 and 2 database is created -- a,b

This behavior is inconsistent due to the shared check .


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Laxminarayan Choudhury <laxminarayan.choudhury@boomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant