-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cfl_record_accessor: cfl_ra_key: Implement generic CFL based record accessor #9566
Open
cosmo0920
wants to merge
3
commits into
master
Choose a base branch
from
cosmo0920-implement-cobj-based-record-accessor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,455
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
force-pushed
the
cosmo0920-implement-cobj-based-record-accessor
branch
from
November 8, 2024 05:01
1ef920c
to
1cdce4d
Compare
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
November 8, 2024 09:22
Due to the use cases we have, where record accessor patterns will be used go beyond logs, it will apply to metrics and traces, for hence I think the following changes are necessary:
The change proposed, is to have a flb_cfl_record_accessor(struct cfl_variant *var) or flb_cfl_record_accessor(struct cfl_kvlist *kvist) so it can be used for any component inside Fluent Bit. |
cosmo0920
force-pushed
the
cosmo0920-implement-cobj-based-record-accessor
branch
from
November 14, 2024 09:00
1cdce4d
to
110c1bb
Compare
cosmo0920
changed the title
cobj_record_accessor: cobj_ra_key: Implement cobj based record accessor
cfl_record_accessor: cfl_ra_key: Implement generic CFL based record accessor
Nov 14, 2024
cosmo0920
force-pushed
the
cosmo0920-implement-cobj-based-record-accessor
branch
from
November 14, 2024 09:06
110c1bb
to
6ec10b9
Compare
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
…eric CFL based RA Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
force-pushed
the
cosmo0920-implement-cobj-based-record-accessor
branch
from
November 14, 2024 09:12
6ec10b9
to
e6a9305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we didn't implement CFL based record accessor. Which is also called as cobj.
This leads that we're not able to access nested cobjets in processor plugins.
To resolve this, I implemented cobj based record accessor and that infrastructure, cobj_ra_key.
In cobj based record accessor, the same mechanism of parser for record accessor syntax is able to use.
So, I didn't implement cobj specific parser of that syntax.
The main difference of the accessor is creating cobj based record accessor related sturct and use it there.
Other part is mostly copy and paste and then adjust for the operation of cobj.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
The written down test cases are not causing memory leaks:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.