Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_prometheus_exporter: Return 204 on no metrics #9614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jplitza
Copy link

@jplitza jplitza commented Nov 18, 2024

Especially when using log_to_metrics or directly after startup, it might well be that no metrics are available yet. This isn't an error condition, so don't return a 4xx code!

Fixes #9366


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Especially when using log_to_metrics or directly after startup, it might well be that no metrics are available yet. This isn't an error condition, so don't return a 4xx code!

Signed-off-by: Jan-Philipp Litza <jplitza@users.noreply.github.com>
@jplitza
Copy link
Author

jplitza commented Nov 26, 2024

@edsiper Thanks for triggering the Actions! The failing test about in_kubernetes on macos and the failing build on s390x don't seem to be related to my change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server returned HTTP status 404 Not Found
1 participant