Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: switch to use lxc #603

Merged
merged 7 commits into from
Dec 8, 2023
Merged

github: switch to use lxc #603

merged 7 commits into from
Dec 8, 2023

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Dec 6, 2023

vagrant on macos is fragile recently, try to use lxc.

@kenhys
Copy link
Contributor Author

kenhys commented Dec 6, 2023

This is WIP to check whether it is available.

I'm not sure available lxc images on GitHub actions, so I'll replace target afterwards.

@daipom
Copy link
Contributor

daipom commented Dec 6, 2023

Great!! We have to fix the current unstable CI. Thanks!
I'll consider it too!

@kenhys kenhys force-pushed the use-lxd branch 14 times, most recently from 2199b68 to 7bde35e Compare December 8, 2023 01:22
vagrant on macos is fragile recently, try to use lxc.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
since v5.0.2, user/group is changed to be kept.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys kenhys marked this pull request as ready for review December 8, 2023 03:26
Note that ubuntu-latest has switched to CGroup V2, so can't launch
CGroup V1 container by default.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys
Copy link
Contributor Author

kenhys commented Dec 8, 2023

https://github.com/fluent/fluent-package-builder/actions/runs/7137422452/job/19437720881
Except on AmazonLinux 2023, it seems work expectedly.

@kenhys
Copy link
Contributor Author

kenhys commented Dec 8, 2023

waiting CI.

@kenhys kenhys requested a review from daipom December 8, 2023 05:28
EPEL is not supported in AmazonLinux 2023.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys
Copy link
Contributor Author

kenhys commented Dec 8, 2023

deb and rpm CI has passed.

@kenhys
Copy link
Contributor Author

kenhys commented Dec 8, 2023

@daipom all checks has passed!

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks! LGTM!

@daipom
Copy link
Contributor

daipom commented Dec 8, 2023

Note: We can remove Vagrantfile, but it may be useful to use the environments locally.
It would be fine to leave it for now.

@daipom
Copy link
Contributor

daipom commented Dec 8, 2023

@kenhys This will be squash-merged.
If there is any information that should be kept from each commit message, I'd appreciate it if you could summarize it in the first comment of the PR.

@kenhys kenhys merged commit c3463c8 into fluent:master Dec 8, 2023
22 checks passed
@kenhys kenhys deleted the use-lxd branch December 8, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants