Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix failing Test (CGroup V1) #675

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Aug 21, 2024

It appears that now the default remote images is https://images.lxd.canonical.com.

I don't know why, but we can't remove images.
The following command does nothing, so this step fails.

lxc remote remove images

It appears that now the default `remote images` is
https://images.lxd.canonical.com.

I don't know why, but we can't remove `images`.
The following command do nothing, so this step fails.

    lxc remote remove images

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@daipom daipom marked this pull request as ready for review August 21, 2024 09:00
@daipom daipom changed the title Draft: ci: fix failing Test (CGroup V1) ci: fix failing Test (CGroup V1) Aug 21, 2024
@daipom daipom requested a review from kenhys August 21, 2024 09:00
@daipom
Copy link
Contributor Author

daipom commented Aug 21, 2024

CI has passed.

@kenhys
Copy link
Contributor

kenhys commented Aug 22, 2024

I'm not sure but even though target LXD version (we are using) seems different, recently similar changes was introduced, IMHO.

https://discourse.ubuntu.com/t/lxd-4-0-10-lts-has-been-released/46687
https://discourse.ubuntu.com/t/new-lxd-image-server-available-images-lxd-canonical-com/43824

Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit fac6264 into fluent:master Aug 22, 2024
54 checks passed
@daipom daipom deleted the ci-fix-lxc-image-setup-for-cgroup-v1 branch August 22, 2024 02:10
@daipom
Copy link
Contributor Author

daipom commented Aug 22, 2024

Thanks! I see!

daipom added a commit that referenced this pull request Nov 8, 2024
It appears that now the default `remote images` is
https://images.lxd.canonical.com.

I don't know why, but we can't remove `images`.
The following command do nothing, so this step fails.

    lxc remote remove images


ref. #675

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants